Skip to content

Check return codes of ParseFromArray calls in tests #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check return codes of ParseFromArray calls in tests #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ jobs:
env:
CC: clang
CXX: clang++
CXXFLAGS: -Wno-nullability-extension
BUILD_TYPE: ${{ matrix.build_type }}
steps:
- run: brew install doxygen graphviz protobuf
Expand Down
4 changes: 2 additions & 2 deletions test/t/bool/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ TEMPLATE_TEST_CASE("write bool field and check with libprotobuf", "",
SECTION("false") {
pw.add_bool(1, false);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE_FALSE(msg.b());
}

SECTION("true") {
pw.add_bool(1, true);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.b());
}
Expand Down
8 changes: 4 additions & 4 deletions test/t/bytes/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,23 @@ TEMPLATE_TEST_CASE("write bytes field and check with libprotobuf", "",
SECTION("empty") {
pw.add_string(1, "");

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.s().empty());
}

SECTION("one") {
pw.add_string(1, "x");

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.s() == "x");
}

SECTION("string") {
pw.add_string(1, "foobar");

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.s() == "foobar");
}
Expand All @@ -43,7 +43,7 @@ TEMPLATE_TEST_CASE("write bytes field and check with libprotobuf", "",

pw.add_string(1, data);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.s().size() == 3);
REQUIRE(msg.s()[1] == static_cast<char>(2));
Expand Down
6 changes: 3 additions & 3 deletions test/t/double/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,23 @@ TEMPLATE_TEST_CASE("write double field and check with libprotobuf", "",
SECTION("zero") {
pw.add_double(1, 0.0);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.x() == Approx(0.0));
}

SECTION("positive") {
pw.add_double(1, 4.893);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.x() == Approx(4.893));
}

SECTION("negative") {
pw.add_double(1, -9232.33);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.x() == Approx(-9232.33));
}
Expand Down
10 changes: 5 additions & 5 deletions test/t/enum/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,39 +14,39 @@ TEMPLATE_TEST_CASE("write enum field and check with libprotobuf", "",
SECTION("zero") {
pw.add_enum(1, 0L);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.color() == TestEnum::Color::BLACK);
}

SECTION("positive") {
pw.add_enum(1, 3L);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.color() == TestEnum::Color::BLUE);
}

SECTION("negative") {
pw.add_enum(1, -1L);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.color() == TestEnum::Color::NEG);
}

SECTION("max") {
pw.add_enum(1, std::numeric_limits<int32_t>::max() - 1);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.color() == TestEnum::Color::MAX);
}

SECTION("min") {
pw.add_enum(1, std::numeric_limits<int32_t>::min() + 1);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.color() == TestEnum::Color::MIN);
}
Expand Down
6 changes: 3 additions & 3 deletions test/t/fixed32/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,23 @@ TEMPLATE_TEST_CASE("write fixed32 field and check with libprotobuf", "",
SECTION("zero") {
pw.add_fixed32(1, 0);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i() == 0);
}

SECTION("max") {
pw.add_fixed32(1, std::numeric_limits<uint32_t>::max());

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i() == std::numeric_limits<uint32_t>::max());
}

SECTION("min") {
pw.add_fixed32(1, std::numeric_limits<uint32_t>::min());

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i() == std::numeric_limits<uint32_t>::min());
}
Expand Down
10 changes: 5 additions & 5 deletions test/t/int32/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,39 +14,39 @@ TEMPLATE_TEST_CASE("write int32 field and check with libprotobuf", "",
SECTION("zero") {
pw.add_int32(1, 0L);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i() == 0L);
}

SECTION("positive") {
pw.add_int32(1, 1L);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i() == 1L);
}

SECTION("negative") {
pw.add_int32(1, -1L);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i() == -1L);
}

SECTION("max") {
pw.add_int32(1, std::numeric_limits<int32_t>::max());

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i() == std::numeric_limits<int32_t>::max());
}

SECTION("min") {
pw.add_int32(1, std::numeric_limits<int32_t>::min());

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i() == std::numeric_limits<int32_t>::min());
}
Expand Down
2 changes: 1 addition & 1 deletion test/t/message/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ TEMPLATE_TEST_CASE("write message field and check with libprotobuf", "",
}

TestMessage::Test msg;
msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));
REQUIRE(msg.submessage().s() == "foobar");

}
Expand Down
2 changes: 1 addition & 1 deletion test/t/nested/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ TEMPLATE_TEST_CASE("write nested message fields and check with libprotobuf", "",
pw.add_int32(2, 77);

TestNested::Test msg;
msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i() == 77);
REQUIRE(msg.sub().i() == 88);
Expand Down
4 changes: 2 additions & 2 deletions test/t/repeated/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ TEMPLATE_TEST_CASE("write repeated fields and check with libprotobuf", "",
SECTION("one") {
pw.add_int32(1, 0L);

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i().size() == 1);
REQUIRE(msg.i(0) == 0L);
Expand All @@ -27,7 +27,7 @@ TEMPLATE_TEST_CASE("write repeated fields and check with libprotobuf", "",
pw.add_int32(1, std::numeric_limits<int32_t>::max());
pw.add_int32(1, std::numeric_limits<int32_t>::min());

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i().size() == 5);
REQUIRE(msg.i(0) == 0L);
Expand Down
6 changes: 3 additions & 3 deletions test/t/repeated_packed_fixed32/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ TEMPLATE_TEST_CASE("write repeated packed fixed32 field and check with libprotob
const std::array<uint32_t, 1> data = {{ 17UL }};
pw.add_packed_fixed32(1, std::begin(data), std::end(data));

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i().size() == 1);
REQUIRE(msg.i(0) == 17UL);
Expand All @@ -33,7 +33,7 @@ TEMPLATE_TEST_CASE("write repeated packed fixed32 field and check with libprotob
const std::array<uint32_t, 4> data = {{ 17UL, 0UL, 1UL, std::numeric_limits<uint32_t>::max() }};
pw.add_packed_fixed32(1, std::begin(data), std::end(data));

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i().size() == 4);
REQUIRE(msg.i(0) == 17UL);
Expand Down Expand Up @@ -67,7 +67,7 @@ TEMPLATE_TEST_CASE("write from different types of iterators and check with libpr
pw.template add_packed_fixed<uint32_t>(1, it, eod);
}

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.i().size() == 5);
REQUIRE(msg.i(0) == 1);
Expand Down
6 changes: 3 additions & 3 deletions test/t/string/writer_test_cases.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,23 @@ TEMPLATE_TEST_CASE("write string field and check with libprotobuf", "",
SECTION("empty") {
pw.add_string(1, "");

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.s().empty());
}

SECTION("one") {
pw.add_string(1, "x");

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.s() == "x");
}

SECTION("string") {
pw.add_string(1, "foobar");

msg.ParseFromArray(buffer.data(), buffer.size());
REQUIRE(msg.ParseFromArray(buffer.data(), buffer.size()));

REQUIRE(msg.s() == "foobar");
}
Expand Down
Loading