Fix transpose codec on dimension-reducing selections#435
Merged
Conversation
🦋 Changeset detectedLatest commit: f11da6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Closes #427 A transpose codec's order is defined over the array's full rank. When a selection drops dimensions (e.g. integer indexing), the output has lower rank than the order, so getStrides asserts "Order length must match the number of dimensions." and the read fails — e.g. reading a 2D thumbnail from a 3D array stored with a transpose codec. Project the native order onto the surviving axes so a dimension-reducing read keeps the array's native layout instead of throwing. BasicIndexer now exposes the original axis index of each output dimension, and the array context's getStrides uses those to remap the order. A full read of a transposed array and a slice of it now report consistent strides; the full-rank path is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #427
A transpose codec's order is defined over the array's full rank. When a
selection drops dimensions (e.g. integer indexing), the output has lower
rank than the order, so
getStridesasserts "Order length must match thenumber of dimensions." and the read fails.
Project the native order onto the surviving axes so a dimension-reducing
read keeps the array's native layout instead of throwing.
BasicIndexernow exposes the original axis index of each output dimension, and the
array context's
getStridesuses those to remap the order. A full read ofa transposed array and a slice of it now report consistent strides and the
full-rank path is unchanged.