Stop BytesCodec from mutating its input buffer#433
Merged
Conversation
Fixes #431 BytesCodec byte-swaps big-endian data in place. When an uncompressed chunk is served from `withByteCaching`, the store hands back the same Uint8Array on every cache hit, so each decode re-swaps the cached buffer. The result is that repeated reads of the same chunk alternate between correct and corrupt values. These changes copy before swapping on both encode and decode so the codec never mutates a buffer it doesn't own. The extra copy only happens on the big-endian-on-little-endian path; the common path is untouched.
🦋 Changeset detectedLatest commit: 13ad340 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
manzt
changed the title
BytesCodec from mutating its input buffer
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #431
BytesCodec byte-swaps big-endian data in place. When an uncompressed chunk is served from
withByteCaching, the store hands back the same Uint8Array on every cache hit, so each decode re-swaps the cached buffer. The result is that repeated reads of the same chunk alternate between correct and corrupt values.These changes copy before swapping on both encode and decode so the codec never mutates a buffer it doesn't own. The extra copy only happens on the big-endian-on-little-endian path; the common path is untouched.