Skip to content

treewide: general cleanup and security improvements#106

Merged
NotAShelf merged 57 commits into
nextfrom
notashelf/push-roulmxlutryy
Jun 16, 2026
Merged

treewide: general cleanup and security improvements#106
NotAShelf merged 57 commits into
nextfrom
notashelf/push-roulmxlutryy

Conversation

@NotAShelf

@NotAShelf NotAShelf commented Jun 15, 2026

Copy link
Copy Markdown
Member

Improvements, refactorings, enhancements, cleanups, rewrites, etc.

Primarily a cleanup of cryptographic handling for secrets and a rewrite of the notification delivery system. I've gotten annoyed by various parts of the codebase as I was tracing through stuff, so I cleaned up as I went. Not sorry for the diff.

LLM usage disclosure: I've used Claude Haiku (4.6?) and DeepSeek V4 Flash as """intelligent""" (I'm being generous here) grep/mv to find some of the patterns I have missed, and move files around. Logical changes are all mine. All code paths touched by LLMs have been meticulously reviewed by the operator (me). The changes have been reviewed several times over to verify.

Security 📈

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ibebf1c2c6c8c410daa1e6e6dfe7a49cd6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I918835226107f9e9011a11636a16d8646a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I2b24bf540ad9a4b36fa1e630bb548ffb6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I2b8dac85126f881ee459384b1097ebe86a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I8b5ed2e56811cd70631d1d081bed82e16a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ibb45e8a24ea2b0c2135de4b1487c154a6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I6b4123c1d8f2b4d8a6fb54db959c72116a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ic9c0891d9dfe16d20855729c6ecd90646a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I028920e3ac1f75d31881168e8bf0012b6a6a6964
@NotAShelf NotAShelf marked this pull request as ready for review June 15, 2026 14:36
@NotAShelf NotAShelf requested a review from amaanq June 15, 2026 19:24
NotAShelf added 17 commits June 15, 2026 22:44
…ling

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I8a53017a2273a108be61fca3698e694b6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Iaa313225c2f30ece6e0d64d13b22a86a6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Iffd826979a27f5162b1dda86a8a073b66a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I40db636c8992e53656e9dccc511ea90c6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ia609e4d7b936c17ac04354f59598efbd6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I99af6e9aceee9bc4176b506f3ed31bcd6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ie7da972130139ff26d0f32040b656ffd6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ia1ce96150633e417ded510ffa9f719066a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I22c1a5b8ab93a4e750567245edb69fa16a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ie1eaa13743b8886a502575eb9f214d826a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I533959155cada2677931fe3ee10d96096a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I983d6510b8ea239fa7aa331f9202ca926a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I0eb9ece22006eb6b34636bf25fb8ca206a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I9155e595e5f80cf528e0eb727c7d2ba56a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I80d19c189826b2a99f8f2e091691bdaa6a6a6964
…check tests

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I846326d6c446a0b67eb8ae313367b2ca6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ibffb4235c96688965327c4199a1c5cec6a6a6964
@NotAShelf NotAShelf force-pushed the notashelf/push-roulmxlutryy branch from 0003e5a to 02eea60 Compare June 15, 2026 19:45
…m files

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Icacab91f23e8f21bea8415b936523c8f6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I39d52599517691bc5161158afc64ee136a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I0ac02ed8db563a0a026bd8655507b3e46a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Idf84d3bb194c5a9a348a264fc5701dee6a6a6964
Nix is case-sensitive for flake ref schemes; "GitHub:" is rejected while
"github:" works.

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ib5b66cfed7aecb4001e35365f424c9de6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I9566c939650006a6c61be6e05459b92c6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I11ded79775cbbe9922fa70ea5c22583e6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I1b114c08ef582953cfb9f5f11d1d48096a6a6964
@NotAShelf NotAShelf force-pushed the notashelf/push-roulmxlutryy branch from 0ffcbce to a81c18a Compare June 16, 2026 07:54
NotAShelf added 15 commits June 16, 2026 11:09
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ib822939e16f8abb550fc175564107c766a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I4b07a70cc018c53eb75dc0c2724a91826a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I51f8b857ed116edadd659bc8e6a4e4356a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Icb92a56b2e971fd1a8b4a5bb6b3d770a6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: If55070440a1fa8b283ded3bed7db1d506a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I2037686ba6b889fb2eb0d626cec6a9c26a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ib65c64f09d2b986b3e908224419097ce6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ib2e3eb8982254a109ec2f62faa860f2d6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I7cf3a56b64abf5bd50790b7d320f2b6e6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I08f7f772ae22f6b6c2959209e4f407c76a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ia113b71c3bd6864ad7d792558b8020396a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Id70f1f0a4d0c1d02ad615f8cd78fbc6c6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I574def00f6bf36a4cc1f98a1e1ce317f6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I048fb7a95e2424bedca39c670197004d6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Icdfaab1f247c6ed122bf223e2d82a3586a6a6964
@NotAShelf NotAShelf requested a review from faukah June 16, 2026 12:34
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Icd9e8ceeb979242ddccc94287ef11ada6a6a6964
…mports

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ib3153aefbd1bd48ffe67eac91c550e8e6a6a6964
@NotAShelf NotAShelf changed the base branch from main to next June 16, 2026 14:20
@NotAShelf

Copy link
Copy Markdown
Member Author

Merging to next to split into multiple reviewable PRs. I went a bit overboard, sorry.

@NotAShelf NotAShelf merged commit 1a0f598 into next Jun 16, 2026
30 of 31 checks passed
@NotAShelf NotAShelf deleted the notashelf/push-roulmxlutryy branch June 16, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants