Fix sketchybar invocation to work with non-Homebrew installs#5
Open
klockeph wants to merge 1 commit into
Open
Conversation
URL(fileURLWithPath: sketchybarPath) only works when the binary is at a hardcoded well-known Homebrew path. Users on Nix, MacPorts, or any other package manager have sketchybar on their PATH but not at /opt/homebrew or /usr/local, so the process would launch the wrong path or fail entirely. Drop the path-guessing logic and always invoke via /usr/bin/env so the system PATH is used to resolve the binary regardless of how it was installed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL(fileURLWithPath: sketchybarPath)only works when the binary is at a hardcoded well-known Homebrew path. That is becauseURLonly works with full paths, not with just"sketchybar", which is the default argument if the detection logic fails.Users on Nix, MacPorts, or any other package manager have sketchybar on their
$PATHbut not at/opt/homebrewor/usr/local, so the process would launch the wrong path or fail entirely. Drop the path-guessing logic and always invoke via/usr/bin/envso the system$PATHis used to resolve the binary regardless of how it was installed.(Tested with nix)