Skip to content

fix(wizard): progress indicator instead of disabled button while checking (#680) #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malpern merged 1 commit into from
Jun 2, 2026
Merged

fix(wizard): progress indicator instead of disabled button while checking (#680) #710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions Sources/KeyPathAppKit/InstallationWizard/WizardCommunicationPage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,19 +89,19 @@
// Action buttons
VStack(spacing: WizardDesign.Spacing.elementGap) {
if commStatus.isSuccess {
Button(nextStepButtonTitle) {

Check warning on line 92 in Sources/KeyPathAppKit/InstallationWizard/WizardCommunicationPage.swift

View workflow job for this annotation

GitHub Actions / code-quality 

Interactive UI element (Button/Toggle/Picker) should have .accessibilityIdentifier() modifier. See ACCESSIBILITY_COVERAGE.md (require_accessibility_identifier)
navigateToNextStep()
}
.buttonStyle(WizardDesign.Component.PrimaryButton())
.keyboardShortcut(.defaultAction)
.padding(.top, WizardDesign.Spacing.sectionGap)

Button("Re-check Status") {

Check warning on line 99 in Sources/KeyPathAppKit/InstallationWizard/WizardCommunicationPage.swift

View workflow job for this annotation

GitHub Actions / code-quality 

Interactive UI element (Button/Toggle/Picker) should have .accessibilityIdentifier() modifier. See ACCESSIBILITY_COVERAGE.md (require_accessibility_identifier)
Task { await checkCommunicationStatus() }
}
.buttonStyle(WizardDesign.Component.SecondaryButton())
} else if commStatus.canAutoFix {
Button(commStatus.fixButtonText) {

Check warning on line 104 in Sources/KeyPathAppKit/InstallationWizard/WizardCommunicationPage.swift

View workflow job for this annotation

GitHub Actions / code-quality 

Interactive UI element (Button/Toggle/Picker) should have .accessibilityIdentifier() modifier. See ACCESSIBILITY_COVERAGE.md (require_accessibility_identifier)
Task { await performAutoFix() }
}
.buttonStyle(WizardDesign.Component.PrimaryButton(isLoading: isFixing))
Expand All @@ -110,19 +110,25 @@
.frame(minHeight: 44)
.padding(.top, WizardDesign.Spacing.itemGap)

Button("Re-check Status") {

Check warning on line 113 in Sources/KeyPathAppKit/InstallationWizard/WizardCommunicationPage.swift

View workflow job for this annotation

GitHub Actions / code-quality 

Interactive UI element (Button/Toggle/Picker) should have .accessibilityIdentifier() modifier. See ACCESSIBILITY_COVERAGE.md (require_accessibility_identifier)
Task { await checkCommunicationStatus() }
}
.buttonStyle(WizardDesign.Component.SecondaryButton())
.disabled(isFixing)
} else if commStatus == .checking || isAuthTesting {
Button("Checking...") {}
.buttonStyle(WizardDesign.Component.PrimaryButton(isLoading: true))
.disabled(true)
.frame(minHeight: 44)
.padding(.top, WizardDesign.Spacing.itemGap)
// Show an honest progress indicator rather than a disabled
// button, which reads as a frozen/unresponsive control (#680).
HStack(spacing: WizardDesign.Spacing.labelGap) {
ProgressView()
.controlSize(.small)
Text("Checking…")
.foregroundStyle(.secondary)
}
.frame(minHeight: 44)
.padding(.top, WizardDesign.Spacing.itemGap)
.accessibilityIdentifier("wizard-comm-checking-indicator")
} else {
Button("Re-check Status") {

Check warning on line 131 in Sources/KeyPathAppKit/InstallationWizard/WizardCommunicationPage.swift

View workflow job for this annotation

GitHub Actions / code-quality 

Interactive UI element (Button/Toggle/Picker) should have .accessibilityIdentifier() modifier. See ACCESSIBILITY_COVERAGE.md (require_accessibility_identifier)
Task { await checkCommunicationStatus() }
}
.buttonStyle(WizardDesign.Component.PrimaryButton())
Expand Down Expand Up @@ -445,7 +451,7 @@
Task {
if let nextPage = await stateMachine.getNextPage(for: systemState, issues: issues),
nextPage != stateMachine.currentPage
{

Check warning on line 454 in Sources/KeyPathAppKit/InstallationWizard/WizardCommunicationPage.swift

View workflow job for this annotation

GitHub Actions / code-quality 

Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
stateMachine.navigateToPage(nextPage)
} else {
stateMachine.navigateToPage(.summary)
Expand Down
Loading