fix: Tier-3 minor fixes — dead stub removal + telemetry quit flush (#693, #690)

[malpern]

Two small Tier-3 cleanups.

#693 — PackDetailView.copyValidationErrorsToClipboard() was an empty placeholder, never called, with no validation-error state to copy (the real impl is in LiveKeyboardOverlayView). Deleted as dead code.

#690 — KindaVim telemetry flushed on a ~5s timer with no final flush in deinit, losing up to one interval on quit. Now calls the existing MainActor-safe flushNow() from applicationWillTerminate (no-op when disabled).

[claude]

Code Review

Summary: Two small Tier-3 cleanups — a dead stub removal and a telemetry quit-flush fix. Both changes are minimal, correct, and well-scoped.

---

#693 — Dead stub removal (PackDetailView+Helpers.swift)

✅ Clean removal. copyValidationErrorsToClipboard() was never called, had no state to operate on, and had no implementation. Deleting it is the right call — empty placeholders create false impressions of available functionality and accrue as quiet tech debt.

No concerns here.

---

#690 — Telemetry quit flush (App.swift, KindaVimTelemetryStore.swift)

✅ Correct fix. A one-line call to an already-tested flushNow() from applicationWillTerminate. Placement before kanataManager?.cleanupSync() is appropriate.

Concurrency is safe. KindaVimTelemetryStore is @MainActor, and Swift's SDK annotations make NSApplicationDelegate callbacks implicitly @MainActor — the synchronous call compiles correctly without a bridging await.

Minor nit — comment references issue number. Per project convention, issue references belong in the PR description rather than inline comments. The WHY ("up to one ~5s flush interval would otherwise be dropped") is the genuinely non-obvious bit worth keeping; the ticket reference (#690) could be dropped:

// Before:
// Flush pending KindaVim telemetry so counters aren't lost on quit (up to one
// ~5s flush interval would otherwise be dropped — see #690). No-op when disabled.

// Suggested:
// Flush pending telemetry — up to one ~5s debounce interval can otherwise be
// lost on quit. No-op when telemetry is disabled.

Not a blocker — nit-level only.

Test coverage: flushNow() itself is already tested; the integration here is a single delegation call, so no new test is needed.

deinit comment update is clean — removing the stale TODO and pointing to the now-implemented fix is good housekeeping.

---

Summary

Area	Status
Correctness	✅ Both changes are correct
Concurrency safety	✅ MainActor isolation is sound
Project conventions	✅ Minor comment-style nit only
Test coverage	✅ Adequate for the scope
Risk	✅ Low — no logic changes, no new code paths

Verdict: Looks good to merge. The comment nit is optional.