Skip to content

test(lint): tighten seam regex + drop reference-only suites (#698) #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malpern merged 1 commit into from
Jun 1, 2026
Merged

test(lint): tighten seam regex + drop reference-only suites (#698) #707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions Tests/KeyPathTests/Lint/TestSeamLintTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,23 @@ final class TestSeamLintTests: XCTestCase {
/// Pre-existing suites that use a hazard type but still extend XCTestCase directly.
/// Migrate these to KeyPathTestCase and remove them here. Never add new entries.
private static let allowList: Set<String> = [
// Real-I/O suites: the seam fixes their pgrep hang but they also do real
// saveConfiguration/updateStatus/resetToDefaultConfig that needs deeper mocking.
"ErrorHandlingTests.swift",
"FacadeLintTests.swift",
"KeyPathTests.swift",
"PrivilegedOperationsCoordinatorTests.swift",
"RuntimeCoordinatorResetTests.swift",
"SystemRequirementsTests.swift",
"VHIDDeviceManagerTests.swift",
"WizardPureLogicTests.swift"
// The seam's own test (sets testPIDProvider per test, asserts real-pgrep fallthrough).
"VHIDDeviceManagerTests.swift"
]

func testCoordinatorSuitesUseKeyPathTestCase() throws {
let testsDir = repositoryRoot().appendingPathComponent("Tests/KeyPathTests")

// Type used as a constructor `Type(` or as a type annotation `: Type`.
// Type used as a constructor `Type(` or as a type annotation `: Type`. The
// leading \b avoids matching a method name that merely ends in the type, e.g.
// `testDoNotBypassInstallerEngine()`.
let hazard = try NSRegularExpression(
pattern: #"(RuntimeCoordinator|InstallerEngine|SystemValidator|VHIDDeviceManager)\s*\(|:\s*(RuntimeCoordinator|InstallerEngine|SystemValidator|VHIDDeviceManager)\b"#
pattern: #"\b(RuntimeCoordinator|InstallerEngine|SystemValidator|VHIDDeviceManager)\s*\(|:\s*(RuntimeCoordinator|InstallerEngine|SystemValidator|VHIDDeviceManager)\b"#
)

guard let enumerator = FileManager.default.enumerator(at: testsDir, includingPropertiesForKeys: nil) else {
Expand Down
Loading