Skip to content

Update eslint to 0.14.1#4

Open
Dremora wants to merge 2 commits into
makepanic:masterfrom
Dremora:eslint-0.12
Open

Update eslint to 0.14.1#4
Dremora wants to merge 2 commits into
makepanic:masterfrom
Dremora:eslint-0.12

Conversation

@Dremora
Copy link
Copy Markdown

@Dremora Dremora commented Jan 22, 2015

Beyond simply updating the version number, a few other changes had to be made, namely:

  • no-global-strict and no-yoda rules were changed to global-strict and yoda.
  • New lines were added to the end of every js file (a new default in eslint).
  • Only using officially documented API. There is now no need to pass configuration object anywhere as filters only expect results, and a message object contains severity.

All options (config, rulesdir and format) were kept intact.

@jonathanKingston
Copy link
Copy Markdown

@makepanic please can this be merged in as it fixes issues I was encountering. The upgrade from 0.12 to 0.14.1 should be simple after this also.

@Dremora Dremora changed the title Update eslint to 0.12 Update eslint to 0.14.1 Feb 18, 2015
@Dremora
Copy link
Copy Markdown
Author

Dremora commented Feb 18, 2015

Updated to 0.14.1.

@jonathanKingston
Copy link
Copy Markdown

@makepanic can this be merged into master, it looks good to go.

@fsmanuel
Copy link
Copy Markdown

👍

@boushley
Copy link
Copy Markdown

Let's merge this thing!

@graycodes
Copy link
Copy Markdown

Is there any update on this? @makepanic

@jonathanKingston
Copy link
Copy Markdown

Does the fork I made solve the issues here? (I wouldn't normally do this however this repo seems a little stagnant - hence the fork in the first place)

https://github.com/jonathanKingston/broccoli-lint-eslint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants