Fix stale People-page description test assertion#1375
Merged
Conversation
Commit 7e497aa changed the People page meta description (dropped "postdocs" since the lab has never had one), but test_people_description still asserted the old "...students, postdocs, and alumni" string, leaving the suite red. Align the assertion with the current copy in website/views/people.py. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up: commit 7e497aa ("Changed language for page_meta since we have never had a postdoc") updated the People page meta description to drop "postdocs", but
test_people_descriptionstill asserted the old"...students, postdocs, and alumni"string — so the test suite was red onmaster.This aligns the assertion with the current copy in
website/views/people.py("Meet the faculty, students, and alumni …").No production behavior change; test-only.
🤖 Generated with Claude Code