Skip to content

FIX: Fix ListSelfDateProfileSerializer's field.#85

Open
10000001a wants to merge 1 commit into
masterfrom
fix/self-date-profile-serializer
Open

FIX: Fix ListSelfDateProfileSerializer's field.#85
10000001a wants to merge 1 commit into
masterfrom
fix/self-date-profile-serializer

Conversation

@10000001a
Copy link
Copy Markdown
Collaborator

Summary

  • 셀소 list 관련 serializer를 수정하였습니다.
  • 테스트용 객체와 api 응답내용을 비교하는 메소드를 list API용과 retrieve API용으로 분리하였습니다.

References

Checklist

  • 로컬에서 잘 작동하는지 확인했는가
  • 테스트를 작성했는가
  • Base branch 를 알맞게 설정하였는가
  • Reviewers, Assignees, Labels 등을 적절히 지정했는가

Comment on lines +236 to +242
def _check_response_and_expected_when_call_retrieve_api(self, dictionary, instance):
assert_that(dictionary['id']).is_equal_to(instance.id)
assert_that(dictionary['nickname']).is_equal_to(instance.nickname)
assert_that(dictionary['height']).is_equal_to(instance.height)
assert_that(dictionary['body_type']).is_equal_to(instance.body_type)
assert_that(dictionary['tags']).is_equal_to(instance.tags)
assert_that(dictionary['image']).is_equal_to(instance.image)
assert_that(dictionary['religion']).is_equal_to(instance.religion)
assert_that(dictionary['is_smoke']).is_equal_to(instance.is_smoke)
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

보기가 불편해서 순서를 셀소 등록하는 순서로 변경하였습니다.

@10000001a 10000001a requested a review from maitracle May 16, 2020 13:51
@10000001a 10000001a self-assigned this May 16, 2020
@10000001a 10000001a added REFACTOR 개선작업을 하는 경우 FIX 버그를 수정하는 경우 and removed REFACTOR 개선작업을 하는 경우 labels May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FIX 버그를 수정하는 경우

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant