fix: stabilize retrieval status reachability pbt - #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainline Intent
Intent:
int_3c69f7bcStatus:
proposedTitle: 稳定 retrieval status reachability PBT
What changed
把 TestPropertyClassifyRetrievalStatusAllBranchesReachable 从依赖 rapid 随机抽中四个状态,改为先用显式 witness 验证 current、superseded、abandoned、stale 都真实可达,再保留 rapid 随机输入检查 classifier 只返回合法 retrieval status。
Why
最新 PR 合并后的 Full PBT 在 main push 上失败,因为 CI 使用 -rapid.checks=20 时随机样本没有命中 stale 分支,导致测试把概率未命中误判成分支不可达。显式 witness 能保留 branch reachability 的回归价值,同时消除低样本下的 flake。
Decisions
Subsystems: engine, context-retrieval, property-tests