config: add absolute size / position getters / setters and window rules#1069
config: add absolute size / position getters / setters and window rules#1069Ktrompfl wants to merge 2 commits into
Conversation
|
I'd prefer for this to be a single action
All fields take numbers as arguments but also the string "keep", to indicate that this value should be preserved. Naturally not all combinations are valid. For example, it would not make sense to set x1=0, x2=100, width=keep, since you cannot follow all three instructions in general. |
6d5359f to
fe096c1
Compare
fe096c1 to
50cb149
Compare
669b0d4 to
560737d
Compare
|
Is this what you have in mind or should I keep the size / position setters as separate functions in jay-config and only expose them as a combined action in toml-config? |
|
I've only looked at the SetPosition data structure for now, not at the business logic, but I don't think it can be correct as is. The three states number/"keep"/omitted must be distinguished. Currently it seems that you conflate "keep" and omitted. If a user sets x1=2, then I'd expect x2 to stay as is, so the window width might increase or decrease. However, if a user sets x1=2,width="keep", then x2 should be adjusted dynamically to preserve the width. |
Implements #1052.