feat: add --sort time option to sort repos by starred_at#139
Open
Yzeph wants to merge 1 commit into
Open
Conversation
Changes: - Modify GraphQL query to fetch starredAt via edges - Store starred_at in Repository model - Extend --sort from boolean flag to Choice(alphabetical|time) - Sort repos within each category by star time when --sort time is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--sortfrom a boolean flag to accept--sort alphabetical(existing behavior) or--sort time(new)--sort timeto sort repositories within each category by star time (newest first)starredAttimestamp from GitHub GraphQL API via edges (was previously not collected)Breaking change
--sortis no longer a boolean flag. Existing usage--sortmust be changed to--sort alphabetical.Test plan
starred --username <user> --token <token> --sort timeand verify repos within each category are ordered newest-firststarred --username <user> --token <token> --sort alphabeticaland verify categories are sorted alphabetically (existing behavior unchanged)