Skip to content

Fix rare use of undefined variable#196

Open
starboerg wants to merge 1 commit into
magjac:masterfrom
starboerg:patch-1
Open

Fix rare use of undefined variable#196
starboerg wants to merge 1 commit into
magjac:masterfrom
starboerg:patch-1

Conversation

@starboerg

@starboerg starboerg commented Jun 7, 2021

Copy link
Copy Markdown

Variable x2 was used undefined in case of polygons without y-extend. Defaulting x2 to zero works around this issue.

x2 was used undefined in case of polygons without y-extend. Defaulting x2 to zero is works around this issue.
@codecov

codecov Bot commented Jun 7, 2021

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@magjac

magjac commented Feb 5, 2022

Copy link
Copy Markdown
Owner

@starboerg Thanks for the contribution and apologies for the delay. Can you provide an example that trigger this? Or even better, add a test case?

@starboerg

Copy link
Copy Markdown
Author

@magjac I did not dive too deep into the code, just stumbled upon this issue. I use a sequence of graphs and transition them into each other:
graphviz.transition(function () { return d3.transition("main").ease(d3.easeLinear).delay(0).duration(500); });
Likely a horizontal line element in the graphs triggers this, but I did not keep any example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants