Add environment variable overrides for file loaded properties#30
Open
svdberg wants to merge 2 commits into
Open
Add environment variable overrides for file loaded properties#30svdberg wants to merge 2 commits into
svdberg wants to merge 2 commits into
Conversation
added 2 commits
March 16, 2018 10:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We internally use the functionality of overriding loaded properties with prefixed environment variables.
We convert the names of these env variables to property keys with a simple replacement scheme. This PR implements this logic. Feel free to do anything with it you like, just sharing in case there is any interest in this approach.
Example:
thrift.client=proxycan be overridden with the
PREFIX_THRIFT_CLIENTenvironment variable, wherePREFIXis configurable.