Skip to content

fix: format trim times as minutes and seconds#1570

Open
gTanusri wants to merge 1 commit into
magic-peach:mainfrom
gTanusri:fix/format-trim-times
Open

fix: format trim times as minutes and seconds#1570
gTanusri wants to merge 1 commit into
magic-peach:mainfrom
gTanusri:fix/format-trim-times

Conversation

@gTanusri

Copy link
Copy Markdown

Summary

  • Add a formatTrimTime helper for MM:SS.d trim display values
  • Show formatted start/end labels and clip summary in the trim control
  • Keep trim inputs numeric so users can still edit raw seconds
  • Add formatter unit tests for padding, decimals, and invalid values

Tests

  • Not run: local dependency install is blocked in this environment
    • npm install fails with an existing React 19 / @testing-library/react 14 peer dependency conflict
    • npm install --legacy-peer-deps fails with ENOSPC: no space left on device

Closes #78

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

@servis is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @gTanusri!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @gTanusri

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:testing Testing labels Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Intermediate level - 35 pts type:bug Bug fix type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Format trim times as MM:SS instead of raw seconds

1 participant