Skip to content

Update Feed.php#84

Open
Delgraf wants to merge 1 commit into
mageplaza:masterfrom
Delgraf:patch-1
Open

Update Feed.php#84
Delgraf wants to merge 1 commit into
mageplaza:masterfrom
Delgraf:patch-1

Conversation

@Delgraf

@Delgraf Delgraf commented Jun 2, 2026

Copy link
Copy Markdown

Replace deprecated (boolean) cast with (bool) for PHP 8.5 compatibility

Replace deprecated (boolean) cast with (bool) for PHP 8.5 compatibility
@likearocket

Copy link
Copy Markdown

Changes in the latest version (1.5.16) broke navigation on our websites which then took me a few hours to identify the cause. This needs investigating as this is a backend module and shouldn't affect theme or modules?

@Delgraf

Delgraf commented Jun 5, 2026

Copy link
Copy Markdown
Author

We encountered the same problem as likearocket. Replacing the deprecated (boolean) cast with (bool) solves the problem. Merge please.

@likearocket

Copy link
Copy Markdown

We encountered the same problem as likearocket. Replacing the deprecated (boolean) cast with (bool) solves the problem. Merge please.

Would this be the change that broke our site? Didn't change any code to solve the problem, just rolled back the module and opened a ticket with Mageplaza which I'm awaiting a response.

@Delgraf

Delgraf commented Jun 5, 2026

Copy link
Copy Markdown
Author

It could be... The same thing happened to us. We have PHP 8.5, and in this version, the boolean cast has been deprecated and replaced with bool. Making the change makes everything go back to normal. You can see if this is the problem by running a compile. You should see the error in red.

@likearocket

Copy link
Copy Markdown

It could be... The same thing happened to us. We have PHP 8.5, and in this version, the boolean cast has been deprecated and replaced with bool. Making the change makes everything go back to normal. You can see if this is the problem by running a compile. You should see the error in red.

We're still on PHP 8.4 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants