Tfa customer - #31
Open
brunoalvarenga wants to merge 5 commits into
Open
Conversation
… in - EXPERIMENTAL!
- Currently the cookie is tied to the admin user. Hook in with customer_entity for frontend. - Make foreign key to admin user nullable, now that we support another entity. - To support multiple entities, let consumer select it through an extra argument on relevant methods. While in here: - Storage for the cookie value is tight: hashes go obsolete. Be prepared. TODO: - Consumers of refactored methods, specifically for customer - generateCookie is really a resource method? - reach concensus about expiration time. - do we need to ensure no hash collisions exist or is the chance for abuse sufficiently low? - Add a cookie collection and store browser/device to allow presenting and deleting cookies for lost/stolen/etc. machines.
Make the cookie work with customers:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.