Convert to IndexedDB

[Travja]

This pull request introduces a major refactor to the attribute and class data persistence logic, migrating from direct localStorage usage to a new, more robust persistence layer. It also adds new dependencies and scripts to support testing and IndexedDB-based storage. The most significant changes are the replacement of direct storage access with new persistence service functions, improved error handling for storage quota issues, and code style improvements for consistency.

Persistence Layer Refactor:

• Replaced all direct localStorage access in attribute-store.ts and class-store.svelte.ts with new functions from editor-persistence (such as savePersistedAttributes, getPersistedAttribute, deletePersistedAttribute, savePersistedClass, etc.), centralizing and improving data storage logic. This enables better error handling, quota management, and future extensibility. [1] [2] [3] [4] [5]
• Added new methods to hydrate attributes from persisted records and updated the attribute loading logic to use the new persistence API. [1] [2]
• Enhanced error handling for storage quota exceedance, providing clearer feedback and state management when saves fail due to size limits. [1] [2]

Code Quality and Consistency:

• Refactored code for style consistency, such as using arrow functions, updating variable names, and improving array and object handling for clarity and maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
• Updated the attribute store initialization and mapping logic for improved reliability and future extensibility. [1] [2]

Testing and Dependency Updates:

• Added new dependencies: idb, fake-indexeddb, jsdom, and vitest to support IndexedDB-backed storage and enable robust testing of the new persistence logic. [1] [2]
• Added a test script to package.json for running tests with Vitest.

These changes lay the groundwork for more reliable, scalable, and testable data persistence in the application.

[Copilot]

Pull request overview

Migrates editor persistence from direct localStorage reads/writes to an IndexedDB-backed persistence layer (editor-persistence) with shared save/quota handling, plus adds Vitest-based tests to validate persistence behavior.

Changes:

• Added a new IndexedDB persistence module (migration from legacy localStorage, read/write helpers, DB schema + IDB operations).
• Updated skill/class/attribute stores and route loaders to hydrate from the new persistence layer and to centralize quota/“memory only” warning state.
• Added Vitest + jsdom configuration and new test suites for persistence and quota-state handling.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
vite.config.ts	Configures Vitest to run with jsdom.
src/routes/+layout.ts	Ensures editor data is hydrated before the app runs.
src/routes/+layout.svelte	Adds persistence warnings/unsupported banner + formatting adjustments.
src/routes/(app)/[type=istype]/[id]/edit/+page.ts	Hydrates persistence before loading editor entities.
src/routes/(app)/[type=istype]/[id]/+page.ts	Hydrates persistence and loads skill via store API.
src/data/skill-store.svelte.ts	Switches skill persistence to editor-persistence + quota-state helpers.
src/data/persistence-state.ts	Introduces shared quota detection + save-state decision helpers.
src/data/persistence-state.test.ts	Tests quota detection and persistence save-state behavior.
src/data/editor-session.ts	Centralizes one-time hydration of skill/class/attribute stores.
src/data/editor-persistence.ts	Implements cache-backed IndexedDB persistence API + legacy migration flow.
src/data/editor-persistence.test.ts	Tests legacy migration and normalization for structured-clone safety.
src/data/editor-persistence-unsupported.test.ts	Tests behavior when IndexedDB is unavailable.
src/data/editor-persistence-shared.ts	Defines DB schema/constants and normalization helper.
src/data/editor-persistence-legacy.ts	Reads legacy localStorage formats and clears legacy storage.
src/data/editor-persistence-db.ts	Implements IndexedDB open/read/write/replace helpers using idb.
src/data/class-store.svelte.ts	Switches class persistence to editor-persistence + quota-state helpers.
src/data/attribute-store.ts	Switches attribute persistence to editor-persistence + hydration and quota flow.
package.json	Adds vitest, jsdom, fake-indexeddb, and idb plus test script.
package-lock.json	Locks new dependencies required for IndexedDB + testing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 6 comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/data/skill-store.svelte.ts:365

• This always logs Saved <name> even when the IndexedDB write failed (including quota failures). Consider logging only on result.ok, and/or logging a different message when persistence is skipped/failed so diagnostics match reality.

			if (!result.ok) {
				if (!result.quotaExceeded) {
					console.error(this.name + ' Save error', result.error);
				} else {
					const persistState = finishPersistenceSave(
						{
							name: this.name,
							tooBig: this.tooBig,
							acknowledged: this.acknowledged
						},
						result
					);
					this.tooBig = persistState.state.tooBig;
					this.acknowledged = persistState.state.acknowledged;
					saveError.set(this);
				}
			} else {
				const persistState = finishPersistenceSave(
					{
						name: this.name,
						tooBig: this.tooBig,
						acknowledged: this.acknowledged
					},
					result
				);
				this.previousName = this.name;
				this.tooBig = persistState.state.tooBig;
				this.acknowledged = persistState.state.acknowledged;
				if (persistState.clearSaveError && get(saveError)?.name === this.name) {
					saveError.set(undefined);
				}
			}

			this.saveDebounceTimeout = undefined;
			skillStore.isSaving.set(false);
			console.log('Saved ' + this.name + ' 😎');
		}, 600); // Adjust the debounce delay as needed

[Copilot]

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.