ALLOW SETTING EMPTY LVMEXTENSION#3
Open
arjunkc wants to merge 1 commit into
Open
Conversation
The variable LVMEXTENSION is set by default to something like "-disk". If you
attempt to set an empty LVMEXTENSION using
lvmsnapshot -e "" create <lvname>
Then the variable OPT_LVMEXTENSION will be empty when the command-line arguments are
parsed. This means that the following test will fail
if [ ! -z $OPT_LVMEXTENSION ]; then
and LVMEXTENSION will continue to contain its default value. So I added an extra
flag that ISSET_OPT_LVMEXTENSION to show that the argument was parsed. This
allows for an empty LVMEXTENSION to be set using
-e ""
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable LVMEXTENSION is set by default to something like "-disk". If you
attempt to set an empty LVMEXTENSION using
Then the variable OPT_LVMEXTENSION will be empty when the command-line arguments are
parsed. This means that the following test will fail
and LVMEXTENSION will continue to contain its default value. So I added an extra
flag that ISSET_OPT_LVMEXTENSION to show that the argument was parsed. This
allows for an empty LVMEXTENSION to be set using