Add schedule timeline updates and V2 roadmap preview by macintoshwan · Pull Request #32 · macintoshwan/Artemis

macintoshwan · 2026-04-22T18:36:55Z

Summary

This PR finalizes the current schedule phase and prepares the repository for a stable V1 period.

Included changes

Complete schedule timeline refactor baseline for multi-day usage on the current branch
Fix build-blocking TypeScript issues found in deployment logs
Add README updates:
- mark V1 as stable for daily use
- announce planned V2 direction (AI-first + unified model exploration)

Why

The goal is to close this phase cleanly, merge to main, and keep a stable version available for at least the next month while V2 planning proceeds in isolation.

Notes

Build has been verified with npm run build.
Follow-up advanced schedule alignment work is tracked separately in issue feat(schedule): 课表视图时间轴对齐与高级布局能力（后续） #31.

Copilot

Pull request overview

Adds a “fixed schedule events” capability (DB + UI) and updates project status messaging to mark V1 as stable while previewing V2 direction.

Changes:

Adds is_fixed_event, schedule_start_at, schedule_end_at to tasks (with an index for fixed events).
Introduces schedule timeline UI + modal for creating fixed-time blocks, and allows clicking a todo to open task details.
Updates base styles for new schedule components and refreshes README status/roadmap.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
supabase/migrations/005_add_task_schedule_columns.sql	Adds schedule-related columns + partial index for fixed events.
src/types/index.ts	Extends `Task` type with schedule-related fields.
src/styles/base.css	Adds styling for date/time inputs, schedule timeline, and modal sizing.
src/components/TodoListContainer.tsx	Plumbs through `onSelectTodoTask` callback.
src/components/TodoList.tsx	Makes todo items keyboard/click selectable and adjusts layout for project tag.
src/components/ScheduleTimeline.tsx	New schedule timeline component that renders free/occupied segments.
src/components/App.tsx	Wires schedule section/modal, derives schedule events, and opens task detail modal from todo list.
README.md	Updates project status to “V1 stable” and adds V2 preview section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-22T18:41:04Z

+        const taskDayKey = rawStart.toISOString().slice(0, 10);
+        const dayStartForTask = new Date(`${taskDayKey}T00:00:00`);
+        const dayEndForTask = new Date(`${taskDayKey}T23:59:59.999`);


taskDayKey 通过 rawStart.toISOString().slice(0, 10) 取的是 UTC 日期；而 todayKey/scheduleDate 是本地日期字符串。两者混用会导致在非 UTC 时区下把事件归到错误的日期列（例如本地凌晨/深夜的事件）。建议用本地时间生成 dateKey（基于 rawStart.getFullYear()/getMonth()/getDate()），并确保后续 dayStartForTask 也基于同一套本地日历日。

Copilot · 2026-04-22T18:41:04Z

+  const [scheduleDate, setScheduleDate] = useState(defaultDate ?? new Date().toISOString().slice(0, 10));
+  const [startTime, setStartTime] = useState('08:00');
+  const [endTime, setEndTime] = useState('09:00');


scheduleDate 默认值使用 new Date().toISOString().slice(0, 10) 取的是 UTC 日期，用户本地时区可能会默认到“昨天/明天”。建议改用与全局一致的本地日期生成方式（例如复用 getLocalDateKey()），保证日期输入的默认值符合用户本地日期。

Copilot · 2026-04-22T18:41:05Z

+  const dates = useMemo(() => {
+    const result: string[] = [];
+    for (let i = 0; i < viewDays; i++) {
+      const d = new Date(todayKey);


这里同样使用 new Date(todayKey) 解析 YYYY-MM-DD，会按 UTC 解析并可能造成日期偏移，进而导致 timeline 的列标题/列数与 todayKey（本地日）不一致。建议用 new Date(${todayKey}T00:00:00) 或拆分年月日构造本地日期。

Suggested change

const d = new Date(todayKey);

const d = new Date(`${todayKey}T00:00:00`);

Copilot · 2026-04-22T18:41:05Z

+    segments.push({
+      kind: 'occupied',
+      startMinute: event.startMinute,
+      endMinute: event.endMinute,
+      id: event.id,
+      name: event.name,
+    });


当存在重叠或乱序数据时（例如后端写入或未来功能引入），这里会在 cursor 已经过了某个时间段的情况下仍然 push 一个从 event.startMinute 开始的 occupied 段，导致总时长被重复计算、渲染高度超过 24h。建议在生成 occupied 段时将开始时间裁剪为 max(cursor, event.startMinute)，或在 normalized 阶段合并/裁剪重叠区间。

Suggested change

segments.push({

kind: 'occupied',

startMinute: event.startMinute,

endMinute: event.endMinute,

id: event.id,

name: event.name,

});

const occupiedStart = Math.max(cursor, event.startMinute);

if (occupiedStart < event.endMinute) {

segments.push({

kind: 'occupied',

startMinute: occupiedStart,

endMinute: event.endMinute,

id: event.id,

name: event.name,

});

}

Copilot · 2026-04-22T18:41:05Z

+  ADD COLUMN IF NOT EXISTS is_fixed_event boolean NOT NULL DEFAULT false,
+  ADD COLUMN IF NOT EXISTS schedule_start_at timestamp with time zone,
+  ADD COLUMN IF NOT EXISTS schedule_end_at timestamp with time zone;
+


当前 schema 允许 is_fixed_event = true 但 schedule_start_at/schedule_end_at 为空或结束早于开始（前端校验可绕过/未来接口可能写入）。建议在 DB 层增加约束（例如 CHECK：(NOT is_fixed_event) OR (schedule_start_at IS NOT NULL AND schedule_end_at IS NOT NULL AND schedule_end_at > schedule_start_at)），以保证数据一致性并减少后续代码中的防御性判断。

Suggested change

-- Enforce valid fixed-event schedule ranges at the database layer

ALTER TABLE public.tasks

ADD CONSTRAINT tasks_fixed_event_schedule_check

CHECK (

(NOT is_fixed_event)

OR (

schedule_start_at IS NOT NULL

AND schedule_end_at IS NOT NULL

AND schedule_end_at > schedule_start_at

)

);

Copilot · 2026-04-22T18:41:06Z

+  is_fixed_event?: boolean;
+  schedule_start_at?: string | null;
+  schedule_end_at?: string | null;


Task 接口顶部注释写的是“严格对齐 Supabase schema”，但这里把 is_fixed_event（DB 中 NOT NULL + DEFAULT false）以及新时间字段都声明成可选属性，会让类型系统允许缺字段的 task 并掩盖数据一致性问题。建议把 is_fixed_event 设为必填 boolean，并将 schedule_start_at/schedule_end_at 设为必填但可空（string | null），与 schema 对齐。

Suggested change

is_fixed_event?: boolean;

schedule_start_at?: string | null;

schedule_end_at?: string | null;

is_fixed_event: boolean;

schedule_start_at: string | null;

schedule_end_at: string | null;

Copilot · 2026-04-22T18:41:06Z

+      const d = new Date(todayKey);
+      d.setDate(d.getDate() + i);
+      const y = d.getFullYear();
+      const m = String(d.getMonth() + 1).padStart(2, '0');
+      const dd = String(d.getDate()).padStart(2, '0');
+      dates.push(`${y}-${m}-${dd}`);


这里用 new Date(todayKey) 解析 YYYY-MM-DD 的日期字符串在 JS 中会按 UTC 解析（且不同时区可能出现日期偏移），随后再用 setDate 叠加天数，容易导致生成的 dates 列表和本地 todayKey 不一致。建议用 new Date(${todayKey}T00:00:00)（本地 0 点）或手动拆分 year/month/day 构造，避免时区偏移。

macintoshwan added 13 commits April 20, 2026 17:58

add schedule

08ebffb

fix ui

920d74c

fix ui

4b6897c

fix ui

b6ca97e

fix ui

7f52f10

fix ui

b1a5e8e

fix ui

54549ae

fix ui

b188d32

fix ui

b775c72

add multi day

8773273

fix multiday

55714ae

fix multiday

0443a15

docs: update README with V1 stable status and V2 preview

d70a0aa

Copilot AI review requested due to automatic review settings April 22, 2026 18:36

Copilot started reviewing on behalf of macintoshwan April 22, 2026 18:37 View session

macintoshwan merged commit 4e3f719 into main Apr 22, 2026
4 checks passed

macintoshwan deleted the feature/schedule branch April 22, 2026 18:37

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add schedule timeline updates and V2 roadmap preview#32

Add schedule timeline updates and V2 roadmap preview#32
macintoshwan merged 13 commits into
mainfrom
feature/schedule

macintoshwan commented Apr 22, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const d = new Date(todayKey);
	const d = new Date(`${todayKey}T00:00:00`);

+-- Enforce valid fixed-event schedule ranges at the database layer
+ALTER TABLE public.tasks
+  ADD CONSTRAINT tasks_fixed_event_schedule_check
+  CHECK (
+    (NOT is_fixed_event)
+    OR (
+      schedule_start_at IS NOT NULL
+      AND schedule_end_at IS NOT NULL
+      AND schedule_end_at > schedule_start_at
+    )
+  );

Conversation

macintoshwan commented Apr 22, 2026

Summary

Included changes

Why

Notes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants