fix: loose-schema bug with nested schemas that are already loose#191
Merged
Conversation
- Fixed postwalk walking into schema record types (Predicate, OptionalKey, etc.) causing duplicate s/Keyword entries when nested schemas were already loose. - Added unit tests covering nested loose-schema scenario (Telegram inside Config). - Bumped version to 46.1.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug in the
loose-schemafunction where nested schemas that were already loose would cause aMore than one non-optional/required key schemata: [Keyword Keyword]error.Root Cause
clojure.walk/postwalktreats schema record types (Predicate,OptionalKey, etc.) as maps since they implementIPersistentMap. This caused{s/Keyword s/Any}to be injected into schema type internals. When a schema value was itself already a loose schema (e.g.,TelegraminsideConfig), the walk would add a duplicates/Keywordentry.Fix
Added two guards to the
postwalkpredicate:(not (record? %))— skips schema record types likePredicate,OptionalKey(not (contains? % s/Keyword))— skips maps that already have as/Keywordcatch-all keyChanges
src/common_clj/schema/core.clj: Fixedloose-schemafunctiontest/unit/common_clj/schema/core_test.clj: Addedloose-schema-with-nested-loose-schema-testwith 5 test casesproject.clj: Version bump to46.1.5CHANGELOG.md: Added entry for46.1.5