ci(site): promote docs-site build to a hard gate#62
Merged
Conversation
The site job carried continue-on-error: true, so a broken marketing surface could ship silently. The advisory comment said to flip it to a hard gate once the build had been stable for a release cycle; that has held, so remove continue-on-error and make the docs-site build a required check. Verified locally: pnpm install --frozen-lockfile + next build both pass (Next 16, 16/16 static pages), so the gate is green on flip.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @macanderson, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
macanderson
marked this pull request as ready for review
July 24, 2026 07:13
macanderson
enabled auto-merge (squash)
July 24, 2026 07:13
macanderson
disabled auto-merge
July 24, 2026 07:13
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
continue-on-error: truefrom thesitejob in.github/workflows/ci.yml, promoting the docs-site build from advisory to a required check. A broken marketing surface can no longer merge silently.The prior advisory comment said to flip to a hard gate "once the site build has been stable for a release cycle." That has held, so this makes it real.
Verification
Ran the exact CI steps locally against this branch's
site/:pnpm install --frozen-lockfile→ exit 0pnpm build(Next 16, Turbopack) →✓ Compiled successfully, 16/16 static pagesnode --test tests/*.test.mjs→ 5/5 passSo the gate is green on flip.
Heads-up (not in this PR)
The site build fetches Google Fonts via
next/font/googleat build time — the exact flake class the old advisory comment guarded against. This PR proves it builds once; if font fetches start intermittently failing in CI, that will now block merges (which is the point, but worth knowing).Context
Part of acting on an external code/site review. The review's higher-priority item — the canonical/OG/
og:imageURLs on the live site pointing atcontext-graph-protocol.vercel.appinstead ofcontextgraphprotocol.org— is not fixable in this repo: the live apex is served by a separate repo (macanderson/cgp-website), wherelib/site.tshardcodes the vercel.app origin. That fix is being handled separately.