fix(community/chat/booking): remaining wiring bugs from the completeness sweep#139
Merged
Merged
Conversation
…ess sweep Five real bugs surfaced by a sweep of the flows not yet audited (all client-only): - COMMUNITY: a tag link inside a thread navigated to /student/community?tag=X but the feed never read the `tag` query param, so it landed on the unfiltered feed. Seed the tag filter from useSearchParams (the feed mounts fresh on that nav). - CHAT: a message in a NEW/unopened conversation was silently missed while the recipient sat on /messages — the realtime push only reaches the joined conversation group and the bell is suppressed while they're connected. Poll the conversations list (15s + on focus) so the list + unread heal. - CHAT: the "…is typing" bubble stayed stuck on the recipient after the sender sent — the scheduled TypingStop timer is cleared (not fired) on send. Emit an explicit TypingStop for persisted conversations. - AI CHATBOT: a Q&A turn rendered twice for the rest of the session when the prompt contained PII — the optimistic dedup compared the raw prompt against the server's PII-redacted PromptText. Anchor the dedup on the verbatim assistant responseText instead. - BOOKING: a free (0-fee) booking detail polled the server every 4s forever while Requested — the awaiting-webhook guard didn't require a Payment row. Gate on paymentId != null. tsc + eslint clean. Sweep verified student/provider surfaces, notification prefs, and the remaining admin pages CLEAN; dropped the review→application deep link (provider already sees the PB-005 files); deferred admin payments detail (nav- hidden while payments are off).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five real bugs from a completeness sweep of the flows not yet audited (all client-only):
?tag=Xbut the feed never read the param → unfiltered feed. Seed the tag filter fromuseSearchParams./messages(push only reaches the joined thread; bell suppressed while connected). Poll the conversations list (15s + on focus).TypingStop.PromptText). Anchor dedup on the verbatim assistant response.paymentId != null.tsc/eslintclean. The sweep verified student/provider surfaces, notification prefs, and remaining admin pages clean; dropped the review→application deep link (provider already sees PB-005 files); deferred admin payments detail (nav-hidden while payments off).