feat(review-requests): student attaches files for provider review + completeness feedback (PB-005)#137
Merged
Conversation
…ompleteness feedback (PB-005) The docx bug: a student "can't upload files for the provider to review, and the provider has nowhere to review them — only status changes." The feature did not exist. Built it on the EXISTING document vault (no new storage): - MIGRATION: nullable Document.ScholarshipProviderReviewRequestId FK (SetNull) + ProviderFeedback column on the request. Both nullable — safe, no data change. - Student attaches vaulted files to an open request (UploadDocumentCommand gains an optional review-request link, guarded to the request's own student while it is Submitted/Pending/UnderReview). New "Attach a file" control + download list on the student review-requests page. - Provider sees + downloads the attached files on the incoming-request card (download authz extended: the request's provider may fetch its documents), and gives optional completeness feedback when completing — shown to the student. - DTO carries Documents[] + ProviderFeedback (enriched post-projection). Also fixes the audit-log question: the accept command audited as PaymentCaptured with the summary "captured payment" on EVERY accept, so in free mode (payments off, fee 0, Stripe bypassed) the log still read "captured payment" even though no money moved. Re-audited as a neutral "accepted review request" (the real capture is recorded on the Payment side). Server build clean; 146 unit tests green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docx bug: a student "can't upload files for the provider to review, and the provider has nowhere to review them — only status changes." The feature didn't exist. Built on the existing document vault (no new storage).
Document.ScholarshipProviderReviewRequestIdFK (SetNull) +ProviderFeedbackcolumn. Both nullable → safe.UploadDocumentCommandgains an optional, student-guarded review-request link). New "Attach a file" control + download list on the student page.Also answers the audit-log question: the accept command audited as
PaymentCapturedwith "captured payment" on every accept, so in free mode the log read "captured payment" despite no money moving. Re-audited as a neutral "accepted review request".tsc/eslint/dotnet buildclean; 146 unit tests green.