Skip to content

Fix Pyright type errors in parameter.py and task.py #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hirosassa merged 5 commits into from
May 15, 2026
Merged

Fix Pyright type errors in parameter.py and task.py #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
699abf5
fix ExplicitBoolParameter.__init__ to use super() instead of direct P…
hirosassa May 13, 2026
ff5ec4b
add type annotation
hirosassa May 13, 2026
1527ebe
cast param_value to TaskOnKart
hirosassa May 13, 2026
74f5f32
Merge branch 'master' into fix-type-check-errors
hirosassa May 14, 2026
677666f
Merge branch 'master' into fix-type-check-errors
hirosassa May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gokart/parameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def _warn_on_wrong_param_type(self, param_name, param_value):

class ExplicitBoolParameter(luigi.BoolParameter):
def __init__(self, *args, **kwargs):
luigi.Parameter.__init__(self, *args, **kwargs)
super(luigi.BoolParameter, self).__init__(*args, **kwargs)

def _parser_kwargs(self, *args, **kwargs): # type: ignore
return luigi.Parameter._parser_kwargs(*args, *kwargs)
Expand Down
4 changes: 2 additions & 2 deletions gokart/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ def _to_str_params(task):

return task.to_str_params(only_significant=True)

dependencies = [_to_str_params(task) for task in flatten(self.requires())]
dependencies: list[Any] = [_to_str_params(task) for task in flatten(self.requires())]
dependencies = [d for d in dependencies if d is not None]
dependencies.append(self.to_str_params(only_significant=True))
dependencies.append(self.__class__.__name__)
Expand Down Expand Up @@ -445,7 +445,7 @@ def get_info(self, only_significant=False):
for param_name, param_value in self.param_kwargs.items():
if (not only_significant) or params[param_name].significant:
if isinstance(params[param_name], gokart.TaskInstanceParameter):
params_str[param_name] = type(param_value).__name__ + '-' + param_value.make_unique_id()
params_str[param_name] = type(param_value).__name__ + '-' + cast(TaskOnKart[Any], param_value).make_unique_id()
else:
params_str[param_name] = params[param_name].serialize(param_value)
return params_str
Expand Down