Skip to content

fix type issues in config_params.py and run.py #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hirosassa merged 3 commits into from
May 15, 2026
Merged

fix type issues in config_params.py and run.py #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0f801c
fix type issues in config_params.py and run.py
hirosassa May 13, 2026
df762bc
review suggestion: fix back unnecessary change
hirosassa May 15, 2026
4907fca
Merge branch 'master' into fix-type-config
hirosassa May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gokart/config_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from __future__ import annotations

from typing import Any
from typing import Any, cast

import luigi

Expand Down Expand Up @@ -33,4 +33,4 @@ def get_param_values(cls, params, args, kwargs):
kwargs[task_param_key] = param_value
return super().get_param_values(params, args, kwargs)

return Wrapped
return cast(type[gokart.TaskOnKart[Any]], Wrapped)
6 changes: 3 additions & 3 deletions gokart/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import os
import sys
from logging import getLogger
from typing import Any
from typing import Any, cast

import luigi
import luigi.cmdline
Expand Down Expand Up @@ -102,7 +102,7 @@ def _run_with_retcodes(argv):
sys.exit(retcodes.already_running)
except Exception:
env_params = luigi.interface.core()
luigi.setup_logging.InterfaceLogging.setup(env_params)
luigi.setup_logging.InterfaceLogging.setup(cast(Any, env_params))
retcode_logger.exception('Uncaught exception in luigi')
sys.exit(retcodes.unhandled_exception)

Expand Down Expand Up @@ -142,7 +142,7 @@ def run(cmdline_args=None, set_retcode=True):

_try_tree_info(cmdline_args)
_try_to_delete_unnecessary_output_file(cmdline_args)
gokart.testing.try_to_run_test_for_empty_data_frame(cmdline_args)
gokart.testing.try_to_run_test_for_empty_data_frame(cmdline_args) # pyright: ignore[reportAttributeAccessIssue]

slack_api = _try_get_slack_api(cmdline_args)
event_aggregator = gokart.slack.EventAggregator()
Expand Down