Skip to content

add type narrowing for luigi.build() return value #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hirosassa merged 2 commits into from
May 15, 2026
Merged

add type narrowing for luigi.build() return value #516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
159674d
add type narrowing for luigi.build() return value
hirosassa May 13, 2026
c474394
Merge branch 'master' into type-narrowing-build
hirosassa May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gokart/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import backoff
import luigi
from luigi import LuigiStatusCode, rpc, scheduler, task_register
from luigi.execution_summary import LuigiRunResult

import gokart
import gokart.tree.task_info
Expand Down Expand Up @@ -219,6 +220,7 @@ def _build_task():
)
if task_lock_exception_raised.flag:
raise HasLockedTaskException()
result = cast(LuigiRunResult, result)
if result.status in (LuigiStatusCode.FAILED, LuigiStatusCode.FAILED_AND_SCHEDULING_FAILED, LuigiStatusCode.SCHEDULING_FAILED):
raise GokartBuildError(result.summary_text, raised_exceptions=raised_exceptions)
return _get_output(task) if return_value else None
Expand Down