fix import style for redis.lock and luigi.task_register#515
Merged
Conversation
hiro-o918
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task_lock.py— Usefrom redis.lock import Lockinstead ofredis.lock.Lockattribute accessbuild.py— Usefrom luigi import task_registerinstead ofluigi.task_registerattribute accessMotivation
Pyright does not resolve submodules via attribute chain access (e.g.
redis.lock.Lock) unless the parent package explicitly re-exports them. Switching to direct imports follows the same pattern already used inparameter.pyand resolves 6 Pyright errors.