Skip to content

Refactor ReviewMonitor streaming log rendering#11

Merged
lynnswap merged 5 commits into
mainfrom
codex/review-monitor-streaming-glow
May 26, 2026
Merged

Refactor ReviewMonitor streaming log rendering#11
lynnswap merged 5 commits into
mainfrom
codex/review-monitor-streaming-glow

Conversation

@lynnswap
Copy link
Copy Markdown
Owner

Purpose

Refactor the ReviewMonitor log rendering path around typed monitor log documents and transient streaming animation behavior.

Changes

  • Replace string/suffix-diff monitor rendering with ReviewMonitorLogDocument and ReviewMonitorLogChange append/replace/reload semantics.
  • Keep monitor rendering incremental for appends and grouped replacements while avoiding stale change replay after metadata or hidden command-output updates.
  • Add streaming word fade and reasoning line glow behavior while preserving non-animated progress/event-style log updates.
  • Preserve find/search state across log updates and add regression coverage for grouped replacement, separator-prefixed appends, coalesced progress suffixes, and Reduce Motion behavior.

Testing

  • git diff --check
  • Xcode navigator issues: 0 errors
  • swift test --build-system swiftbuild --no-parallel
  • xcodebuild test -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj -scheme CodexReviewMonitor -destination 'platform=macOS,arch=arm64' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO
  • Codex review against main: no findings

UI Validation

  • Streaming log animation and flicker behavior were validated locally during development; no screenshot artifact is attached.

@lynnswap
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89f0937694

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/ReviewUI/Detail/ReviewMonitorLogScrollView.swift
Copy link
Copy Markdown
Owner Author

@lynnswap lynnswap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap lynnswap merged commit 828c2b8 into main May 26, 2026
1 check passed
@lynnswap lynnswap deleted the codex/review-monitor-streaming-glow branch May 26, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant