Skip to content

Fix/rustdoc warnings#2045#2084

Open
krishnakurtakoti wants to merge 5 commits intolycheeverse:masterfrom
krishnakurtakoti:fix/rustdoc-warnings#2045
Open

Fix/rustdoc warnings#2045#2084
krishnakurtakoti wants to merge 5 commits intolycheeverse:masterfrom
krishnakurtakoti:fix/rustdoc-warnings#2045

Conversation

@krishnakurtakoti
Copy link
Copy Markdown

@krishnakurtakoti krishnakurtakoti commented Mar 11, 2026

Fixes issues/2045

Comment thread lychee-bin/src/options.rs Outdated
Comment thread lychee-bin/src/options.rs Outdated
Comment thread lychee-bin/src/options.rs Outdated
Comment thread lychee-bin/src/options.rs Outdated
Comment thread lychee-lib/src/ratelimit/mod.rs Outdated
Comment thread lychee-lib/src/types/request_error.rs Outdated
Comment thread lychee-lib/src/types/input/input.rs Outdated
@krishnakurtakoti
Copy link
Copy Markdown
Author

Made suggested changes. Please check.

@thomas-zahner
Copy link
Copy Markdown
Member

thomas-zahner commented Mar 18, 2026

Thank you for applying my suggestions, all changes look good now. However, in the current state the PR does not fix the mentioned issue so there are still things to do.

  • Fix all rustdoc warnings (cargo doc --no-deps still yields warnings)
  • Remove continue-on-error: true in linting step
  • CI doesn't pass, test failures need to be addressed

As a side-note I feel like the current PR description doesn't really help. It's really verbose and contains repeated content from my contents as well as confusing parts (e.g. Rule of Thumb) that seem to come from a LLM. Maybe you could shorten the description to the essential parts, or just leave the first line.

@thomas-zahner
Copy link
Copy Markdown
Member

@katrinafyi now addressed the comment I referenced previously with caa7d5c. Consequently I've updated my above comment.

I recommend you to now rebase this PR on master, so that you can test the changes with this new commit included. You can then remove the line with continue-on-error: true and update the name of the step. Next you should address all warnings/errors which you can now see in the CI step.

@mre
Copy link
Copy Markdown
Member

mre commented Apr 25, 2026

@krishnakurtakoti, can you rebase this branch on top of master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix rustdoc warnings

3 participants