Skip to content

Fix: Update recording for neural setereo node test - #1925

Merged
aljazkonec1 merged 1 commit into
developfrom
fix/neural_depth_node_test_Recording_update
Aug 4, 2026
Merged

Fix: Update recording for neural setereo node test#1925
aljazkonec1 merged 1 commit into
developfrom
fix/neural_depth_node_test_Recording_update

Conversation

@aljazkonec1

@aljazkonec1 aljazkonec1 commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Purpose

With PR #1904 the test started failing due to missing extrinsics in the recording. I added the extrinsics to the mcap file.

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

AI Usage

Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]

Submitted code was reviewed by a human: YES/NO

The author is taking the responsibility for the contribution: YES/NO

Summary by CodeRabbit

  • Tests
    • Updated neural-depth test replay data to use a fetched recording artifact.
    • Improved test coverage reliability with the new recording source.

@aljazkonec1
aljazkonec1 requested a review from moratom August 3, 2026 17:14
@aljazkonec1 aljazkonec1 added the testable PR is ready to be tested - run vanilla tests label Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The neural-depth test now uses a fetched neural_depth_recording.tar artifact. The CMake configuration declares the artifact and passes its location through NEURAL_REPLAY_PATH.

Changes

Neural depth recording

Layer / File(s) Summary
Artifact and test wiring
tests/CMakeLists.txt
The configuration declares neural_depth_recording.tar with its download metadata. The neural-depth test uses neural_depth_recording as NEURAL_REPLAY_PATH.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: aljazdu, asahtik, matictonin

Poem

A rabbit fetched a replay tar,
And placed it where the tests are.
Neural depths now run just right,
With recorded paths in sight.
Hop, verify, and close the bar!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the recording update for the neural stereo node test, which matches the main pull request change despite a minor typo.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/neural_depth_node_test_Recording_update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/CMakeLists.txt`:
- Around line 250-255: The private_data entry for neural_depth_recording.tar
currently uses SHA1 verification; update private_data to accept and prefer
SHA256 or SHA512, then replace this entry’s SHA1 value with the corresponding
stronger digest and ensure file(DOWNLOAD ...) uses it.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cef1309c-ac83-426a-a58d-3a1cccf88899

📥 Commits

Reviewing files that changed from the base of the PR and between 9377bcf and 059de3b.

📒 Files selected for processing (1)
  • tests/CMakeLists.txt
📜 Review details
🔇 Additional comments (1)
tests/CMakeLists.txt (1)

892-892: LGTM!

Comment thread tests/CMakeLists.txt
@aljazkonec1 aljazkonec1 added testable PR is ready to be tested - run vanilla tests and removed testable PR is ready to be tested - run vanilla tests labels Aug 4, 2026
@aljazkonec1
aljazkonec1 merged commit e03b569 into develop Aug 4, 2026
92 of 115 checks passed
@aljazkonec1
aljazkonec1 deleted the fix/neural_depth_node_test_Recording_update branch August 4, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testable PR is ready to be tested - run vanilla tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants