Fix: Update recording for neural setereo node test - #1925
Conversation
📝 WalkthroughWalkthroughThe neural-depth test now uses a fetched ChangesNeural depth recording
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/CMakeLists.txt`:
- Around line 250-255: The private_data entry for neural_depth_recording.tar
currently uses SHA1 verification; update private_data to accept and prefer
SHA256 or SHA512, then replace this entry’s SHA1 value with the corresponding
stronger digest and ensure file(DOWNLOAD ...) uses it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: cef1309c-ac83-426a-a58d-3a1cccf88899
📒 Files selected for processing (1)
tests/CMakeLists.txt
📜 Review details
🔇 Additional comments (1)
tests/CMakeLists.txt (1)
892-892: LGTM!
Purpose
With PR #1904 the test started failing due to missing extrinsics in the recording. I added the extrinsics to the mcap file.
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable
AI Usage
Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Submitted code was reviewed by a human: YES/NO
The author is taking the responsibility for the contribution: YES/NO
Summary by CodeRabbit