Skip to content

Fix to make it work with osticket 1.17 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FacundoCerezo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix to make it work with osticket 1.17 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions webhook.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,38 @@
class WebhookPlugin extends Plugin {

var $config_class = "WebhookPluginConfig";
//we use this to save the correct config in the bootstrap method
//and override the buggy getConfig() from osticket
static $_correctConfig = null;

/**
* We override the getConfig method, because on
* OsTicket 1.7.5 (at least) the getConfig does only
* return the correct config in the bootstrap method.
* On all other occasions, it will return the default
* config.
* @param PluginInstance|null $instance
* @param $defaults
* @return mixed|null
*/
public function getConfig(PluginInstance $instance = null, $defaults = [])
{
if (self::$_correctConfig) {
return self::$_correctConfig;
}
return parent::getConfig($instance, $defaults);
}


/**
* The entrypoint of the plugin, keep short, always runs.
*/
function bootstrap() {
Signal::connect('ticket.created', array($this, 'onTicketCreated'));
Signal::connect('threadentry.created', array($this, 'onTicketUpdated'));
//fix: save correct config, which works only here in bootstrap

self::$_correctConfig = $this->getConfig();
}

/**
Expand Down