Release 2.3.5 - fix phantom 'Microsoft' cache host (2.3.4 regression)#52
Merged
Conversation
…Health.Hosts
v2.3.4 iterated (Get-SPCacheClusterHealth).Hosts, which is a collection of
HostInfo objects whose ToString() starts with
'Microsoft.SharePoint.Internal.Caching...'. Split('.')[0] then yielded
'Microsoft' as a fake short name, and the real DC host fell into the
'Not a cache host' list. Go back to iterating SPDistributedCacheServiceInstance
(Server.Address is the correct short name) and keep Get-SPCacheClusterInfo.Size
for the cluster Size; the graceful defaults from 2.3.4 are preserved.
Fixes #51
Pester Test Results 1 files 15 suites 3s ⏱️ Results for commit 5a2539c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51. Iterate SPDistributedCacheServiceInstance instead of ClusterHealth.Hosts (HostInfo objects whose ToString starts with 'Microsoft...').
Pester 180/0, PSSA 0.