Release 2.3.1 - housekeeping: Clear-SPSLog fix and LogRetentionDays#43
Merged
Conversation
…tionDays Clear-SPSLog filtered on an undefined $logFileName, which resolved to '*' and worked by accident. The function now takes -Filter (default '*.log') and honors -Retention 0 to disable pruning. New config setting LogRetentionDays (default 180, 0 disables) replaces the hardcoded value in the entry script, mirroring JsonHistoryRetentionDays. Fixes #42
Pester Test Results 1 files 15 suites 1s ⏱️ Results for commit d4a358c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42.
Fixed
$logFileNameundefined -> filtered nothing meaningful). Now '*.log' default, with -Filter override. Retention 0 disables pruning.Changed
LogRetentionDays(default 180, 0 disables) replaces the hardcoded value, mirroringJsonHistoryRetentionDays.Pester 180/0, PSSA 0.