feat: update datomic peer and create first implementation for options - #6
Open
lanjoni wants to merge 6 commits into
Open
feat: update datomic peer and create first implementation for options#6lanjoni wants to merge 6 commits into
lanjoni wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @luchiniatwork! Thanks for this amazing tool to manage Datomic migrations.
This PR aims to update some dependencies and upgrade Datomic to use official Datomic Peer library (because Datomic Pro is free now - since April 2023).
Also, this PR tries to implement the first contact of options passed by the client - using now an updated version of
tools.clito manage options and default options. By default, these implementations are to solve the issue #3.At this point we can use it to
runanddry-run! And of course: we can discuss about each implementation if some modifications are necessary, ok? Thanks a lot for your work!