Skip to content

Bypass DNS propagation checks - #132

Merged
lucasdillmann merged 7 commits into
mainfrom
letsencrypt-dns-propagation-bypass
Jul 8, 2026
Merged

Bypass DNS propagation checks#132
lucasdillmann merged 7 commits into
mainfrom
letsencrypt-dns-propagation-bypass

Conversation

@lucasdillmann

Copy link
Copy Markdown
Owner

No description provided.

@lucasdillmann lucasdillmann self-assigned this Jul 8, 2026
@lucasdillmann
lucasdillmann marked this pull request as ready for review July 8, 2026 04:51
@greptile-apps

greptile-apps Bot commented Jul 8, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds DNS propagation bypass support for Let's Encrypt issuance. The main changes are:

  • Optional bypassDnsPropagationChecks certificate parameter.
  • DNS-01 challenge option wiring for the bypass path.
  • OpusDNS and Poweradmin DNS provider adapters.
  • Updated ACME certificate parsing and chain encoding.
  • Dependency, translation, changelog, and frontend style updates.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
certificate/letsencrypt/dynamic_fields.go Adds the optional bypass field with a false default.
certificate/letsencrypt/acme_facade.go Wires the bypass parameter into DNS-01 setup and updates certificate parsing.
certificate/letsencrypt/dns_provider.go Registers the new OpusDNS and Poweradmin DNS providers.
certificate/letsencrypt/dns/opusdns/provider.go Adds the OpusDNS provider configuration.
certificate/letsencrypt/dns/poweradmin/provider.go Adds the Poweradmin provider configuration.

Reviews (2): Last reviewed commit: "Bypass DNS propagation checks" | Re-trigger Greptile

Comment thread certificate/letsencrypt/dynamic_fields.go Outdated
Comment thread certificate/letsencrypt/acme_facade.go
Comment thread certificate/letsencrypt/acme_facade.go
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

@lucasdillmann
lucasdillmann merged commit 2b1b90c into main Jul 8, 2026
4 checks passed
@lucasdillmann
lucasdillmann deleted the letsencrypt-dns-propagation-bypass branch July 8, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant