Virtualize Bytecode View#62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, we would highlight and render every single HTML element of the byte code. After this change, we only render what's in (and just out of) view. This also updates our scroll to logic to only smoothly scroll to when it's within 5 viewports distance, otherwise it just jumps to avoid huge virtual list churn.
The speed up on this is really hard to measure because it's so fast now and blends in with the editor highlighting and parsing. But as an example we went from ~20s hang on 4k lines of dense luau to less than 100ms. So if I had to guess around 200x faster in extreme cases.
Closes #60