Create shared luau worker#23
Open
Nicell wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the new luau.org site can use a very large amount of memory, mostly due to the creation of an analysis worker for every single iframe. For example https://luau.org/syntax/ has 24 iframes. That's a lot of workers that use a baseline of 35MB of memory each.
This PR creates a shared worker for analysis when supported by the browser, which should reduce the amount of memory used significantly.
Currently require autocomplete seems to leak between them. I can't find any other state leaks, but more testing should be done.