[NekosBest] return None on failed API call, guard empty results. - #238
Merged
Conversation
Owner
|
Well, its mostly correct from begin of, its just the enforcement of required User-Agent that was needed since last month which i never did cause i keep forgetting |
Contributor
Author
|
What do you want to use for the |
Owner
It was enforced by the Neko's devs to have user agents so it's needed to be done someday, I'll just use this temporary fix for now until I remember doing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_api_callreturned the sent errorMessageinstead ofNoneon non-200 responses, soif url is Nonenever caught it and the code went on to index into the Message, raisingTypeError: 'Message' object is not subscriptable._api_callnow sends the error message and returnsNoneembedgen/imgembedgenguard against an emptyresultslist (e.g. API returns 200 with no data) before indexing[0]embedgenruns before usage counters are incremented, so failed calls aren't counted as uses