[NBA]: New commands and more - #227
Closed
Evanroby wants to merge 5 commits into
Closed
Conversation
ltzmax
reviewed
Mar 30, 2026
ltzmax
left a comment
ltzmax
left a comment
Owner
There was a problem hiding this comment.
Also, did you test the commands? I don't see the imports from nba api library added here at all, they're pointed on different imports though, the ones I use is different endpoints
| color=0xEE6730, | ||
| ) | ||
| embed.add_field(name="🏟️ Arena", value=location or "Unknown", inline=False) | ||
| if broadcast_str: |
Owner
There was a problem hiding this comment.
I originally removed this, I didn't like this information really, it didn't display anything useful.
| if code == 404: | ||
| return await ctx.send(f"No Pokémon found for `{pokemon}`.") | ||
| return await ctx.send("Could not fetch Pokémon data. Please try again later.") | ||
| async with ctx.typing(): |
Owner
There was a problem hiding this comment.
Needs to be await ctx.typing. the one you're using isn't actually used anymore.
Contributor
Author
|
I can't get it to work, I'm trying a lot of stuffs for 20 mins and can't get anything to work, I'll let you do it. Might re-open one later on for the typing part |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLOBAL
Use
async with ctx.typing()instead ofawait ctx.typing()on all cogs required to do change to avoid bot being in a typing loop.NBA cog:
New commands added:
[p]nba standings [east|west]- LeagueStandingsV3 from CDN[p]nba leaders [pts|reb|ast|stl|blk]- LeagueDashPlayerStats[p]nba player <name>- PlayerCareerStats + CommonPlayerInfo[p]nba roster <team>- CommonTeamRoster[p]nba teamstats <team>- LeagueDashTeamStatsNew formatter functions for each command