Skip to content

[Counting]: Improvements + leaderboard command - #222

Merged
ltzmax merged 1 commit into
ltzmax:masterfrom
Evanroby:counting
Mar 18, 2026
Merged

[Counting]: Improvements + leaderboard command#222
ltzmax merged 1 commit into
ltzmax:masterfrom
Evanroby:counting

Conversation

@Evanroby

Copy link
Copy Markdown
Contributor
  • goaldelete toggle was writing to toggle_progress_delete instead of toggle_goal_delete, so it had zero effect on goal message deletion and was silently misconfiguring progress delete
  • assign_ruin_role would crash with AttributeError on role.name when the role had been deleted from the server (get_role() returns None)
  • on_raw_message_edit ruin branch constructed a discord.Message from a partial payload, guaranteed KeyError on any missing required field, so I refactored _handle_count_ruin to take channel/guild/author directly
  • handle_invalid_count had toggle_delete_after defaulting to True, opposite of the guild default
  • Goal normalization block was writing goals back to DB on every valid count even when nothing changed
  • Dead logger.error after return in set_ruinrole
  • Truncated success message in set_goal ("Current goals" cut off mid-sentence)

Also added the [p]counting leaderboard (lb) command that was documented in the README but never implemented. guild-scoped, paginated 15 per page, shows your rank in the footer if you're outside the visible page

@ltzmax ltzmax left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that progress delete might be because i wrote set_toggle_progress_delete and used progress in some of them... but good catch on these, thanks alot for the pr! ^^,

@ltzmax
ltzmax merged commit 043a599 into ltzmax:master Mar 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants