[Counting]: Improvements + leaderboard command - #222
Merged
Conversation
ltzmax
approved these changes
Mar 18, 2026
ltzmax
left a comment
Owner
There was a problem hiding this comment.
that progress delete might be because i wrote set_toggle_progress_delete and used progress in some of them... but good catch on these, thanks alot for the pr! ^^,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goaldeletetoggle was writing totoggle_progress_deleteinstead oftoggle_goal_delete, so it had zero effect on goal message deletion and was silently misconfiguring progress deleteassign_ruin_rolewould crash withAttributeErroronrole.namewhen the role had been deleted from the server (get_role()returnsNone)on_raw_message_editruin branch constructed adiscord.Messagefrom a partial payload, guaranteedKeyErroron any missing required field, so I refactored_handle_count_ruinto takechannel/guild/authordirectlyhandle_invalid_counthadtoggle_delete_afterdefaulting toTrue, opposite of the guild defaultlogger.errorafterreturninset_ruinroleset_goal("Current goals" cut off mid-sentence)Also added the
[p]counting leaderboard(lb) command that was documented in the README but never implemented. guild-scoped, paginated 15 per page, shows your rank in the footer if you're outside the visible page