[Enforce]: Multiple fixes & improvements. - #221
Merged
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to sneak into code files before adding anything to my bot, found a few things worth fixing such as:
antispam.stamp()was never called so rate limiting on tos prompts did nothingred_delete_data_for_usersilently did nothing for uncached users,get_user()returnsNone, so I switched touser_from_id()resetsettingswas callingclear_all()instead ofclear_all_globals(), accidentally wiping everyone's acceptancetos_prompt_antispamdict grew forever, so I added a periodic clear + immediate pop on acceptalso removed an unused
datetimeimport, redundant@commands.is_owner()onset_linksubcommand whose parent already restricts it, wrong docstring onAcceptView(view isn't persistent as it times out) and a type hint onreset_user