Skip to content

DM-42709: Set number of simultaneous connections to front-end server to 10 to m…#132

Open
airnandez wants to merge 1 commit into
mainfrom
tickets/DM-42709
Open

DM-42709: Set number of simultaneous connections to front-end server to 10 to m…#132
airnandez wants to merge 1 commit into
mainfrom
tickets/DM-42709

Conversation

@airnandez

Copy link
Copy Markdown
Contributor

…atch urllib3 default

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov

codecov Bot commented Oct 15, 2025

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
256 2 254 3
View the top 2 failed test(s) by shortest run time
tests/test_http.py::HttpResourcePathConfigTestCase::test_front_end_connections
Stack Traces | 0.003s run time
self = <tests.test_http.HttpResourcePathConfigTestCase testMethod=test_front_end_connections>

    def test_front_end_connections(self):
        # Ensure that when the number of front end connections is not specified
        # the default comes from the number of workers..
        with unittest.mock.patch.dict(os.environ, {}, clear=True):
            config = HttpResourcePathConfig()
>           self.assertEqual(config.front_end_connections, _get_num_workers())
E           AssertionError: 10 != 6

tests/test_http.py:769: AssertionError
tests/test_http.py::HttpResourcePathConfigTestCase::test_back_end_connections
Stack Traces | 0.005s run time
self = <tests.test_http.HttpResourcePathConfigTestCase testMethod=test_back_end_connections>

    def test_back_end_connections(self):
        # Ensure that when the number of back end connections is not specified
        # the default comes from the number of workers.
        with unittest.mock.patch.dict(os.environ, {}, clear=True):
            config = HttpResourcePathConfig()
>           self.assertEqual(config.back_end_connections, _get_num_workers())
E           AssertionError: 10 != 6

tests/test_http.py:785: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@timj

timj commented Oct 15, 2025

Copy link
Copy Markdown
Member

I think a couple of tests are comparing with max(new, default) and now coming up with the wrong answer because new < default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants