DM-50420: Inject variable sources into the template and science images#461
Open
BrunoSanchez wants to merge 2 commits into
Open
DM-50420: Inject variable sources into the template and science images#461BrunoSanchez wants to merge 2 commits into
BrunoSanchez wants to merge 2 commits into
Conversation
BrunoSanchez
force-pushed
the
tickets/DM-50420
branch
from
42a0553 to
29f868a
Compare
BrunoSanchez
changed the title
isullivan
approved these changes
Jun 5, 2026
isullivan
left a comment
isullivan
left a comment
Contributor
There was a problem hiding this comment.
I put my suggested changes together on a new commit. Please look it over and change as needed!
| self.checkHighVariance(template) | ||
| template.setPsf(self._makePsf(template, catalog, wcs)) | ||
| visitId = outputRefs.template.dataId['visit'] if outputRefs is not None else 1000 | ||
| template.setInfo( |
Contributor
There was a problem hiding this comment.
Use template.getInfo().setVisitInfo(VisitInfo(id=visitId)) instead, so that the rest of the exposureInfo is preserved.
|
|
||
| @timeMethod | ||
| def run(self, *, coaddExposureHandles, bbox, wcs, dataIds, physical_filter): | ||
| def run(self, *, coaddExposureHandles, bbox, wcs, dataIds, physical_filter, outputRefs=None): |
Contributor
There was a problem hiding this comment.
I don't like the run method needing to know anything about the outputRefs, that should be handled in runQuantum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add visit information to templates useful for template fake injection