Skip to content

Prototype schema browser#186

Draft
JeremyMcCormick wants to merge 1 commit into
mainfrom
u/JeremyMcCormick/browser-dev
Draft

Prototype schema browser#186
JeremyMcCormick wants to merge 1 commit into
mainfrom
u/JeremyMcCormick/browser-dev

Conversation

@JeremyMcCormick

Copy link
Copy Markdown
Collaborator

Checklist

  • Ran Jenkins
  • Added a release note for user-visible changes to docs/changes

@JeremyMcCormick JeremyMcCormick marked this pull request as draft June 8, 2026 22:46
@JeremyMcCormick JeremyMcCormick force-pushed the u/JeremyMcCormick/browser-dev branch from cd22720 to 3b62510 Compare June 8, 2026 22:49
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
174 1 173 0
View the top 1 failed test(s) by shortest run time
tests/test_browser.py::BrowserTestCase::test_browser_site_icon
Stack Traces | 0.111s run time
self = <tests.test_browser.BrowserTestCase testMethod=test_browser_site_icon>

        def test_browser_site_icon(self) -> None:
            """Render a centered header icon and optional link when configured."""
            schema_yaml = """
    name: demo
    "@id": "#demo"
    tables:
      - name: ChildTable
        "@id": "#ChildTable"
        columns:
          - name: code
            "@id": "#ChildTable.code"
            datatype: int
    """.strip()
    
            with tempfile.TemporaryDirectory(dir=TEST_DIR) as tmpdir:
                schema_path = os.path.join(tmpdir, "icon.yaml")
                output_dir = os.path.join(tmpdir, "browser")
                icon_path = os.path.join(tmpdir, "icon.png")
                with open(schema_path, "w", encoding="utf-8") as f:
                    f.write(schema_yaml)
                with open(icon_path, "wb") as f:
                    f.write(b"\x89PNG\r\n\x1a\n")
    
                render_browser_site(
                    output_dir=output_dir,
                    files=[schema_path],
                    site_icon=icon_path,
                    icon_link_url="https://www.lsst.org",
                )
    
                self.assertTrue(os.path.exists(os.path.join(output_dir, "assets", "site-icon.png")))
                index_soup = get_page_soup_by_title(output_dir, "Home")
    
                # Validate icon link wrapper and image source in rendered home
                # page.
>               self.assertIsNotNone(
                    index_soup.find("a", class_="header-site-icon-link", href="https://www.lsst.org")
                )
E               AssertionError: unexpectedly None

tests/test_browser.py:565: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@JeremyMcCormick JeremyMcCormick force-pushed the u/JeremyMcCormick/browser-dev branch from 3b62510 to f9d35e0 Compare June 16, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant