DM-12006: Improve testing of copyPolymorphic#47
Open
r-owen wants to merge 3 commits into
Open
Conversation
remove copyPolymorphic so subclasses must override it. Update functional.cc accordingly.
since `virtual` is implied.
kfindeisen
approved these changes
Jul 9, 2018
kfindeisen
left a comment
kfindeisen
left a comment
Member
There was a problem hiding this comment.
Looks good; one minor (and out of scope) comment about the overall architecture.
| auto unitNormMap = UnitNormMap(center); | ||
| return std::make_shared<Mapping>( | ||
| return std::make_shared<SeriesMap>( | ||
| unitNormMap.then(UnitMap(naxes).under(mapping1d)).then(*unitNormMap.getInverse())); |
Member
There was a problem hiding this comment.
I wonder if we should standardize whether mappings are returned by value (then) or smart pointer (makeRadialMapping). This code seems to involve way more implicit moves than should be necessary.
Contributor
Author
There was a problem hiding this comment.
You are right; then should probably be changed to return a shared pointer. However, I suggest that be a different ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.