fix(tui): resolve undefined refresh_chrome in _on_stream exit-boundary replay#543
Open
Kailigithub wants to merge 1 commit into
Open
fix(tui): resolve undefined refresh_chrome in _on_stream exit-boundary replay#543Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
_on_stream(), the exit-boundary replay code path (lines 4770-4778) referencesrefresh_chromewhich is not a parameter of the method. This causes aNameErrorat runtime when:doneif refresh_chrome:evaluates an undefined name →NameErrorThe issue was introduced during the exit-boundary replay refactoring where
refresh_chromewas referenced but the variable was only available as a parameter in_update_assistant(), not in_on_stream().Fix
Since this code path already guards with
if found and agent_id == self.current_id:, the sidebar/topbar refresh is always appropriate (we're updating the display for the active agent). Removed the undefinedrefresh_chromeconditional and made the chrome refresh unconditional within thecurrent_idguard block.Also fixed the indentation: the display update block was at the wrong level, causing the
refresh_chromereference to execute outside theagent_id == self.current_idguard.Verification
ruff check frontends/tuiapp_v2.py --select F821→ All checks passedpython3 -m py_compile frontends/tuiapp_v2.py→ No syntax errors