[feat] fix stale graph nodes and minimap viewport mapping#81
Merged
Conversation
8709fc6 to
b33a71e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two user-visible correctness issues in graph lifecycle and minimap viewport mapping.
When snapshots dropped modules, the graph retained stale nodes indefinitely. This caused the UI to display modules that no longer existed in the live stream and could also keep stale rate-tracker state around for removed node pairs.
Separately, the minimap viewport rectangle used an incorrect inverse transform from screen space to world space. The previous code subtracted pan directly without accounting for zoom, so the minimap rectangle drifted from the true viewport position whenever zoom was not
1.0.Root Cause
The graph update path incrementally updated/added nodes but never removed missing ones, while edges were rebuilt each frame. That made node lifetime additive instead of snapshot-consistent.
The minimap conversion inverted
world_to_screenincorrectly by omitting division by zoom in the pan term.Fix
MessageFlowGraph::update_from_snapshotto rebuild a fresh graph/module index from each snapshot, ensuring only current modules exist.pan / zoomand extracted a helper for focused testing.Validation
cargo test(all tests passing)